From e2377e6bad954aeaa7a3487fb7f0152c822e401c Mon Sep 17 00:00:00 2001 From: Debian Science Team Date: Thu, 22 Oct 2020 07:14:29 +0100 Subject: [PATCH] Allow some numba errors on non-amd64, warn on non-x86 Specifying the exception type allows only explicit errors, not silently wrong answers Numba has been observed to give wrong answers on mipsel, and crash on armel (LLVM ERROR) and s390x (segfault). Author: Rebecca N. Palmer Forwarded: no Gbp-Pq: Name numba_fail_32bit.patch --- pandas/core/window/numba_.py | 6 ++++++ pandas/tests/groupby/transform/test_numba.py | 4 ++++ pandas/tests/window/test_apply.py | 2 ++ pandas/tests/window/test_numba.py | 11 +++++++++++ 4 files changed, 23 insertions(+) diff --git a/pandas/core/window/numba_.py b/pandas/core/window/numba_.py index 5d35ec74..d75c1d25 100644 --- a/pandas/core/window/numba_.py +++ b/pandas/core/window/numba_.py @@ -4,6 +4,10 @@ import numpy as np from pandas._typing import Scalar from pandas.compat._optional import import_optional_dependency +import platform +import re +import warnings +warn_numba_platform = "Non-x86 system detected, Numba may give wrong results or crash" if not bool(re.match('i.?86|x86',platform.uname()[4])) else False from pandas.core.util.numba_ import ( check_kwargs_and_nopython, @@ -49,6 +53,8 @@ def generate_numba_apply_func( numba_func = jit_user_function(func, nopython, nogil, parallel) numba = import_optional_dependency("numba") + if warn_numba_platform: + warnings.warn(warn_numba_platform) if parallel: loop_range = numba.prange diff --git a/pandas/tests/groupby/transform/test_numba.py b/pandas/tests/groupby/transform/test_numba.py index ee482571..ae0b086c 100644 --- a/pandas/tests/groupby/transform/test_numba.py +++ b/pandas/tests/groupby/transform/test_numba.py @@ -6,6 +6,7 @@ import pandas.util._test_decorators as td from pandas import DataFrame, option_context import pandas._testing as tm from pandas.core.util.numba_ import NUMBA_FUNC_CACHE +from pandas.compat import is_platform_little_endian @td.skip_if_no("numba", "0.46.0") @@ -41,6 +42,7 @@ def test_check_nopython_kwargs(): @td.skip_if_no("numba", "0.46.0") +@pytest.mark.xfail(condition=not is_platform_little_endian(), reason="Numba may crash on s390x", run=False, strict=False) @pytest.mark.filterwarnings("ignore:\\nThe keyword argument") # Filter warnings when parallel=True and the function can't be parallelized by Numba @pytest.mark.parametrize("jit", [True, False]) @@ -70,6 +72,7 @@ def test_numba_vs_cython(jit, pandas_obj, nogil, parallel, nopython): @td.skip_if_no("numba", "0.46.0") +@pytest.mark.xfail(condition=not is_platform_little_endian(), reason="Numba may crash on s390x", run=False, strict=False) @pytest.mark.filterwarnings("ignore:\\nThe keyword argument") # Filter warnings when parallel=True and the function can't be parallelized by Numba @pytest.mark.parametrize("jit", [True, False]) @@ -115,6 +118,7 @@ def test_cache(jit, pandas_obj, nogil, parallel, nopython): @td.skip_if_no("numba", "0.46.0") +@pytest.mark.xfail(condition=not is_platform_little_endian(), reason="Numba may crash on s390x", run=False, strict=False) def test_use_global_config(): def func_1(values, index): return values + 1 diff --git a/pandas/tests/window/test_apply.py b/pandas/tests/window/test_apply.py index 2aaf6af1..043c61f8 100644 --- a/pandas/tests/window/test_apply.py +++ b/pandas/tests/window/test_apply.py @@ -14,6 +14,8 @@ def test_rolling_apply_invalid_raw(bad_raw): Series(range(3)).rolling(1).apply(len, raw=bad_raw) +from pandas.compat import is_platform_little_endian +@pytest.mark.xfail(condition=not is_platform_little_endian(), reason="Numba may crash on s390x", run=False, strict=False) def test_rolling_apply_out_of_bounds(engine_and_raw): # gh-1850 engine, raw = engine_and_raw diff --git a/pandas/tests/window/test_numba.py b/pandas/tests/window/test_numba.py index 35bdb972..5cc1f819 100644 --- a/pandas/tests/window/test_numba.py +++ b/pandas/tests/window/test_numba.py @@ -6,9 +6,18 @@ import pandas.util._test_decorators as td from pandas import Series, option_context import pandas._testing as tm from pandas.core.util.numba_ import NUMBA_FUNC_CACHE +from pandas.compat import is_platform_32bit, is_platform_little_endian +import platform +import sys +try: + from numba.core.errors import UnsupportedParforsError +except ImportError: + UnsupportedParforsError = ImportError @td.skip_if_no("numba", "0.46.0") +@pytest.mark.xfail(condition=is_platform_32bit(), raises=UnsupportedParforsError, reason="some Numba functionality is not available on 32 bit systems", strict=False) +@pytest.mark.xfail(condition=not is_platform_little_endian(), reason="Numba may crash on s390x", run=False, strict=False) @pytest.mark.filterwarnings("ignore:\\nThe keyword argument") # Filter warnings when parallel=True and the function can't be parallelized by Numba class TestApply: @@ -37,6 +46,7 @@ class TestApply: ) tm.assert_series_equal(result, expected) + @pytest.mark.xfail(condition='mips' in platform.uname()[4].lower() and sys.maxsize<2**33, reason="Numba may give wrong answers on mipsel", strict=False) @pytest.mark.parametrize("jit", [True, False]) def test_cache(self, jit, nogil, parallel, nopython): # Test that the functions are cached correctly if we switch functions @@ -78,6 +88,7 @@ class TestApply: @td.skip_if_no("numba", "0.46.0") +@pytest.mark.xfail(condition=not is_platform_little_endian(), reason="Numba may crash on s390x", run=False, strict=False) def test_use_global_config(): def f(x): return np.mean(x) + 2 -- 2.30.2